> On Aug. 31, 2016, 12:54 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/jobs/configuration-table.html, line 357 > > <https://reviews.apache.org/r/50174/diff/3/?file=1488352#file1488352line357> > > > > Is it too late to comment on the config key pattern? Traditionally, we > > don't have any strict conventions for config names listed anywhere. Since > > we use period as a delimiter to distinguish configs belonging to a > > namespace, I think we should try to avoid using the same in the actual > > config part. > > For example, job.container.single.thread.mode can be > > job.container.single-thread-mode. > > Same for job.container.thread.pool.size, task.callback.timeout.ms and > > task.max.concurrency > > Xinyu Liu wrote: > This config is pretty awkward (so is the name). It's just for fallback to > old runloop if there is any issue with the new AsyncRunLoop. So I don't > expect users to set it normally. Once the AsyncRunLoop stablized, I will > remove this config as well as the old runLoop.
As I mentioned above, I think it is important to clarify in the documentation that this is a fallback option to provide compatibility with versions < 0.11.0. Is it too late to change the config name ? :) - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review147388 ----------------------------------------------------------- On Sept. 7, 2016, 5:16 p.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50174/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 5:16 p.m.) > > > Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > Update samza web docs with new multithreading api, core and configs. > > > Diffs > ----- > > docs/learn/documentation/versioned/api/overview.md > 6712344e84e19883b857e00549db2acb101c7e0e > docs/learn/documentation/versioned/container/event-loop.md > 116238312df7071747cbbc14bc9c46f558755195 > docs/learn/documentation/versioned/jobs/configuration-table.html > 54c52981c3055b398ee60af50eeaf2592ed0e64f > > Diff: https://reviews.apache.org/r/50174/diff/ > > > Testing > ------- > > Test the web pages locally. > > > Thanks, > > Xinyu Liu > >
