----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/ -----------------------------------------------------------
(Updated Sept. 29, 2016, 9:23 p.m.) Review request for samza, Navina Ramesh and Jagadish Venkatraman. Changes ------- Fix some typo in comments. Repository: samza Description ------- Current the error log happens after produce close and reset the exception in later callbacks, which caused the trouble shooting to be harder in cases of multithreading. We should log error before closing and keep atomic reference of the initial exception. Diffs (updated) ----- samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a Diff: https://reviews.apache.org/r/52403/diff/ Testing ------- Tested in jobs deployed in Yarn cluster. Thanks, Xinyu Liu
