> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote:
> > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55
> > <https://reviews.apache.org/r/52168/diff/5/?file=1533539#file1533539line55>
> >
> > What is the value of the container name?
>
> Shanthoosh Venkataraman wrote:
> name of the samza container in which the task is running. With respect to
> current implementation, container name is unique within a job.
>
> Jake Maes wrote:
> Sorry, the question was poorly worded. How is container name useful? Do
> we need it? If so, couldn't we derive it from the container id?
It will be used for debugging purposes in the monitor/client. It logically
belongs to the task hierarchy. To answer questions like finding list of
containers running on a particular host. These questions could be answered from
filter on the container name & preferred host. Adding this also in a way
completes the entire task model.
Currently container name is of the form samza-container-{containerId}. Hence,
we could derive it. But the logic used to generate container id is specific to
samza job model generator and is bound to change. Hence deriving it might not
be a good idea.
- Shanthoosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52168/#review152418
-----------------------------------------------------------
On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52168/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 11:57 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch contains the following changes
> * Http get api to list the complete details of all the tasks that belongs to
> a job.
> * Refactored some methods in coordinator stream, to reuse the existing
> functionality of getting jobConfig from the coordinator stream.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/resource-directory.md
> 79746d1e2eb3491e4bd26c3c7cf6c7efd150d8ef
> docs/learn/documentation/versioned/rest/resources/tasks.md PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
> 13b72fae7815ddaea7ae03a24f1a426ca51613cc
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
> 05a996c98075ea8ed3767af666b9beeb1933f2a6
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala
> df63b97e9d598ecd1840111ba490a723e410d089
> samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala
> 022b480856483059cb9f837a08f97a718bc04c31
> samza-core/src/main/scala/org/apache/samza/util/Util.scala
> c4836f202f7eda1d4e71eac94fd48e46207b0316
> samza-rest/src/main/java/org/apache/samza/rest/model/Partition.java
> PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/rest/model/Task.java PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/job/AbstractJobProxy.java
> 4d8647f3e1e650632e38b47ba5a8a2dac004f545
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/job/JobProxyFactory.java
> 067711a74e5b0d7277a9c8b2d2517b56e9cfbcca
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/job/SimpleYarnJobProxy.java
> a935c98730f85f448c688a6baf2e8ddffdbb2cb4
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/job/SimpleYarnJobProxyFactory.java
> 11d93d4608d23a4e3fb3bfc50dfac35ab6dbdf3c
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/task/SamzaTaskProxy.java
> PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/task/SamzaTaskProxyFactory.java
> PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/rest/proxy/task/TaskProxy.java
> PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/task/TaskProxyFactory.java
> PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/proxy/task/TaskResourceConfig.java
> PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/resources/BaseResourceConfig.java
> PRE-CREATION
>
> samza-rest/src/main/java/org/apache/samza/rest/resources/DefaultResourceFactory.java
> e0224c6bcf4aeaa336e5786ac472482507fcd382
> samza-rest/src/main/java/org/apache/samza/rest/resources/JobsResource.java
> a566db598c284d69ea61af88fdc0851483d5a089
>
> samza-rest/src/main/java/org/apache/samza/rest/resources/JobsResourceConfig.java
> 527482d2ee55747e7b3f9c54c8a3b1afe7ad8797
> samza-rest/src/main/java/org/apache/samza/rest/resources/Responses.java
> PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/rest/resources/TasksResource.java
> PRE-CREATION
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/TestJobsResource.java
> 7db437b348ecd286185898b8f8ab0220d59da71a
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/TestTasksResource.java
> PRE-CREATION
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockInstallationFinder.java
> PRE-CREATION
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockResourceFactory.java
> PRE-CREATION
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxy.java
> PRE-CREATION
>
> samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52168/diff/
>
>
> Testing
> -------
>
> Manual and unit testing has been done to verify the apis.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
