> On Oct. 18, 2016, 11:11 p.m., Fred Ji wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java, > > line 71 > > <https://reviews.apache.org/r/53002/diff/1/?file=1540988#file1540988line71> > > > > nit: this line of comment is not needed since log warn is very clear.
Removed. - Shanthoosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/#review153208 ----------------------------------------------------------- On Oct. 19, 2016, 1:11 a.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53002/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 1:11 a.m.) > > > Review request for samza and Jake Maes. > > > Repository: samza > > > Description > ------- > > This patch aims to not load the monitors if the monitor factory class is not > defined(set) for the monitor in the config. This will enable the users to > turn on/off the monitors in samza-rest easily(just by setting the > monitorFactoryClass config associated with monitor a to empty string.) > > > Diffs > ----- > > build.gradle 98839f2d44569cfe04f12207117668afd593b4df > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java > ce947f7ae1175acc1ee9aa75991c726848072694 > samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java > 4618b54f5af861383df45bf7185622d36d17cd5e > > samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53002/diff/ > > > Testing > ------- > > Unit testing and manual testing are done to verify the functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
