Hi Maksim, I'm in favor of adding Scala 2.12 support as well, thanks for the PR. I have a few questions about the way JavaConverter APIs and some of the conversions in the PR work. I'll try it out locally and update the PR with feedback/questions soon.
Thanks, Prateek On Tue, Mar 28, 2017 at 3:01 PM, Maksim Logvinenko <mlogvine...@gmail.com> wrote: > Hi guys, > > As far as I can understand nobody is against having Scala 2.12 support in > Samza master. Can we merge PR then? > > Best regards, > Maxim Logvinenko > > On 17 March 2017 at 23:42:16, Navina Ramesh (nram...@linkedin.com.invalid) > wrote: > > Thanks for creating the DISCUSS email! > > This is good. It's a good idea to update to 2.12 since it looks like we are > fully backward compatible with older versions. +1 from me. > > Cheers! > Navina > > On Fri, Mar 17, 2017 at 1:34 PM, Jagadish Venkatraman < > jagadish1...@gmail.com> wrote: > > > Thanks for starting this discussion and the patch. +1 for supporting > scala > > 2.12. I assume the changes are fully backwards compatible with scala > 2.10, > > 2.11 (as evidenced by your check-all)? > > > > Also, another observation is that the generated Samza binaries will have > > 2.12 as the suffix for the future release (I this should be totally OK). > > > > > > On Fri, Mar 17, 2017 at 1:26 PM, Maksim Logvinenko < > mlogvine...@gmail.com> > > > wrote: > > > > > Hi guys, > > > > > > I’ve created JIRA and already submitted patch which adds support of > scala > > > 2.12. Here is the ticket: https://issues.apache.org/ > > jira/browse/SAMZA-1135 > > > . > > > Nothing serious: I’ve removed JavaConversions usage (because it’s > marked > > as > > > deprecated now) and bumped kafka and scalatest versions since previous > > > versions don’t have scala 2.12 support. I run ./bin/check-all.sh on my > > > laptop and it was successful for all scala versions (2.10, 2.11 and > 2.12) > > > and for both YARN versions. > > > > > > Thanks, > > > Maxim Logvinenko > > > > > > > > > > > -- > > Jagadish V, > > Graduate Student, > > Department of Computer Science, > > Stanford University > > > > > > -- > Navina R. >
