Hi Jagadish, PR 755 is mis-titled. Its only adding back the tests for the old consumer. The old consumer was already added back in https://github.com/apache/samza/pull/740.
Thanks, Prateek On Wed, Oct 24, 2018 at 12:02 AM Jagadish Venkatraman <jagadish1...@gmail.com> wrote: > > Boris, > > Do users have the option to switch to use the "old" Kafka consumer if they > encounter any issue with the "new" consumer?. If not, should we pull in > https://github.com/apache/samza/pull/755? It is my understanding that > PR-755 adds support for this. > > Thanks, > Jagadish > > On Tue, Oct 23, 2018 at 2:50 PM Boris S <bor...@gmail.com> wrote: > > > Ran build, test and integration test on Linux. > > Verified the signatures. > > > > +1 > > > > On Tue, Oct 23, 2018 at 11:55 AM Prateek Maheshwari <prate...@utexas.edu> > > wrote: > > > > > Hi all, > > > > > > This is a call for a vote on a release of Apache Samza 1.0.0. Thanks to > > > everyone who has contributed to this release. > > > > > > The release candidate can be downloaded from here: > > > http://home.apache.org/~pmaheshwari/samza-1.0.0-rc2/ > > > > > > The release candidate is signed with pgp key 6585B3D7, which can be found > > > on keyservers: https://pgp.mit.edu/pks/lookup?op=get&search=0x6585B3D7 > > > > > > The git tag is release-1.0.0-rc2 and signed with the same pgp key: > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.0.0-rc2 > > > > > > Test binaries have been published to Maven's staging repository, and are > > > available here: > > > https://repository.apache.org/content/repositories/orgapachesamza-1053/ > > > > > > The vote will be open for 72 hours (ending at 12:00 PM PST Friday, > > > 10/26/2018). > > > > > > Please download the release candidate, check the hashes/signature, build > > it > > > and test it, and then please vote: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove (and reason why) > > > > > > For me, I ran check-all.sh, integration tests and verified the SQL > > console > > > in samza-tool tgz. So +1 (non-binding) from my side. > > > > > > Thanks, > > > Prateek > > > > > > > > -- > Jagadish V, > Graduate Student, > Department of Computer Science, > Stanford University
