GitHub user dnishimura opened a pull request: https://github.com/apache/samza/pull/801
SAMZA-1988: Properly suffix modules with direct Scala dependencies with the Scala version. List of modules without a Scala version suffix that have direct Scala dependencies and the direct Scala API calls are in each module: ``` samza-azure { "org.apache.samza.coordinator.AzureJobCoordinator" : [ "scala.collection.immutable.Set (scala-library-2.10.4.jar)", "org.apache.samza.util.SystemClock (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.system.StreamMetadataCache (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.coordinator.JobModelManager (samza-core_2.10-302.1000.1.jar)", "scala.collection.JavaConverters (scala-library-2.10.4.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)", "scala.collection.Map (scala-library-2.10.4.jar)", "scala.collection.convert.Decorators$AsJava (scala-library-2.10.4.jar)", "scala.collection.convert.Decorators (scala-library-2.10.4.jar)", "scala.collection.immutable.Map (scala-library-2.10.4.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.checkpoint.azure.AzureCheckpointManagerFactory" : [ "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)", "scala.Option (scala-library-2.10.4.jar)" ], "org.apache.samza.checkpoint.azure.AzureCheckpointManager" : [ "scala.Option (scala-library-2.10.4.jar)" ], "org.apache.samza.system.eventhub.EventHubConfig" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)", "scala.collection.JavaConversions (scala-library-2.10.4.jar)", "scala.collection.Iterable (scala-library-2.10.4.jar)" ], "org.apache.samza.system.eventhub.producer.AsyncSystemProducer" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-aws { "org.apache.samza.system.kinesis.consumer.KinesisSystemConsumer" : [ "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.system.kinesis.KinesisSystemFactory" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-elasticsearch { "org.apache.samza.system.elasticsearch.ElasticsearchSystemFactory" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ] } samza-sql { "org.apache.samza.sql.interfaces.SqlIOConfig" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-sql-shell { "org.apache.samza.sql.client.impl.SamzaExecutor" : [ "kafka.utils.ZkUtils (kafka_2.10-0.11.0.94.jar)", "scala.collection.Seq (scala-library-2.10.4.jar)", "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.system.kafka.KafkaSystemFactory (samza-kafka_2.10-302.1000.1.jar)", "scala.collection.JavaConversions (scala-library-2.10.4.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-tools { "org.apache.samza.tools.SamzaSqlConsole" : [ "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.system.kafka.KafkaSystemFactory (samza-kafka_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.tools.benchmark.SystemConsumerWithSamzaBench" : [ "org.apache.samza.config.SystemConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)", "scala.Option (scala-library-2.10.4.jar)" ] } samza-log4j { "org.apache.samza.config.Log4jSystemConfig" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.SerializerConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)", "scala.Option (scala-library-2.10.4.jar)" ], "org.apache.samza.logging.log4j.SimpleDiagnosticsAppender" : [ "org.apache.samza.container.SamzaContainerMetrics (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.logging.log4j.serializers.LoggingEventJsonSerde" : [ "org.apache.samza.serializers.JsonSerde (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.logging.log4j.StreamAppender" : [ "org.apache.samza.config.ShellCommandConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.ExponentialSleepStrategy (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.coordinator.JobModelManager (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.HttpUtil (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.metrics.MetricsRegistryMap (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.SerializerConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-log4j2 { "org.apache.samza.config.Log4jSystemConfig" : [ "org.apache.samza.config.StreamConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.SerializerConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)", "scala.Option (scala-library-2.10.4.jar)" ], "org.apache.samza.logging.log4j2.serializers.LoggingEventJsonSerde" : [ "org.apache.samza.serializers.JsonSerde (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.logging.log4j2.StreamAppender" : [ "org.apache.samza.config.ShellCommandConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.TaskConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.ExponentialSleepStrategy (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.coordinator.JobModelManager (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.HttpUtil (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.metrics.MetricsRegistryMap (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.SerializerConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ] } samza-rest { "org.apache.samza.rest.proxy.job.AbstractJobProxy" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.SamzaRestService" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.config.MetricsConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.metrics.MetricsRegistryMap (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.CommandLine (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.resources.TasksResource" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.proxy.task.SamzaTaskProxy" : [ "scala.collection.Seq (scala-library-2.10.4.jar)", "org.apache.samza.config.StorageConfig (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.util.CoordinatorStreamUtil (samza-core_2.10-302.1000.1.jar)", "scala.collection.JavaConverters (scala-library-2.10.4.jar)", "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.metrics.MetricsRegistryMap (samza-core_2.10-302.1000.1.jar)", "scala.collection.convert.Decorators$AsJava (scala-library-2.10.4.jar)", "scala.collection.convert.Decorators (scala-library-2.10.4.jar)", "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.proxy.job.SimpleYarnJobProxy" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.proxy.task.SamzaTaskProxyFactory" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.resources.BaseResourceConfig" : [ "org.apache.samza.config.factories.PropertiesConfigFactory (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.monitor.MonitorLoader" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.monitor.LocalStoreMonitor" : [ "org.apache.samza.util.SystemClock (samza-core_2.10-302.1000.1.jar)", "org.apache.samza.storage.TaskStorageManager (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.monitor.LocalStoreMonitorConfig" : [ "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.SamzaRestApplication" : [ "org.apache.samza.util.Util (samza-core_2.10-302.1000.1.jar)" ], "org.apache.samza.rest.proxy.installation.SimpleInstallationFinder" : [ "org.apache.samza.config.JobConfig (samza-core_2.10-302.1000.1.jar)" ] } ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnishimura/samza samza-1988-scala-version-suffixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/801.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #801 ---- commit 8c03f87b7e7a69237e29a540b1109551ea88c963 Author: Daniel Nishimura <dnishimura@...> Date: 2018-11-09T22:26:13Z Properly suffix modules with direct Scala dependencies with the Scala version ---- ---