atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255300768
########## File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java ########## @@ -51,22 +52,21 @@ * - sessionKey (Scalar) * */ -@SamzaSqlUdf(name = "GetSqlField") +@SamzaSqlUdf(name = "GetSqlField", description = "Get an element from complex Sql field.") Review comment: GetSqlField is kind of limiting as it returns only a String. For instance, we cannot get a sub-record or an array or any other type. Just wondering if other cases work if we return an object from execute ? Or since now we have ability to add more methods to an Udf (although I'm still not clear on how these different methods can be invoked in Udf unless they are fn overloads), is there any other way we could make it return different types ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
