vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator
changes for standby-aware container allocation, and active container failover
URL: https://github.com/apache/samza/pull/903#discussion_r255771228
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/SamzaApplicationState.java
##########
@@ -141,6 +143,36 @@
*/
public final AtomicInteger redundantNotifications = new AtomicInteger(0);
+ /**
+ * Number of container allocations that proceeded because they met standby
container constraints.
Review comment:
I would pick 2 metrics that we care about the most. Often, more metrics add
too much noise. for eg: not sure if the metric for standByStopsComplete is
necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
