mynameborat commented on a change in pull request #915: Consolidating offset
read and write for store-offsets and side-inputs, maintaining backward
compatbility
URL: https://github.com/apache/samza/pull/915#discussion_r256144714
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -562,9 +566,14 @@ private boolean isLoggedStoreValid(String storeName, File
loggedStoreDir) {
(long) new
StorageConfig(config).getChangeLogDeleteRetentionsInMs().get(storeName).get();
}
+ // if the store has no changelogSSP, simply use null
+ SystemStreamPartition changelogSSP = null;
Review comment:
Can we short circuit here as well and return false instead of having it go
through the path of validating offsets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
