[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

[GitBox]

rmatharu commented on a change in pull request #915: Consolidating offset read 
and write for store-offsets and side-inputs, maintaining backward compatbility
URL: https://github.com/apache/samza/pull/915#discussion_r256213370
 
 

 ##########
 File path: 
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
 ##########
 @@ -532,14 +531,19 @@ private void cleanBaseDirsAndReadOffsetFiles() {
             LOG.info("Deleting logged storage partition directory " + 
loggedStorePartitionDir.toPath().toString());
             FileUtil.rm(loggedStorePartitionDir);
           } else {
-            String offset = 
StorageManagerUtil.readOffsetFile(loggedStorePartitionDir, OFFSET_FILE_NAME);
+
+            // if the store has no changelogSSP, simply use null
+            SystemStreamPartition changelogSSP = null;
+            if (changelogSystemStreams.containsKey(storeName))
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services