[GitHub] strkkk opened a new pull request #919: Make config immutable again

[GitBox]

strkkk opened a new pull request #919: Make config immutable again
URL: https://github.com/apache/samza/pull/919
 
 
   Config is supposed to be immutable, but method Map#replaceAll in its default 
implementation mutates the config. Code to check:
   ```
   Map<String, String> m = new HashMap<String, String>() {
     {
        put("foo1", "val1");
        put("baz2", "val3");
     }
   };
   Config conf = new MapConfig(m);
   conf.replaceAll((key,value) -> "newValue");
   System.out.println(conf); // {baz2=newValue, foo1=newValue}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services