strkkk opened a new pull request #921: SAMZA-2105: [elasticsearch, hdfs, kafka] 
code cleanup and refactoring
URL: https://github.com/apache/samza/pull/921
 
 
   1. Added/removed modifiers
   2. Guava optional -> java optional and removed guava from 
samza-elasticsearch module dependencies. Guava optional was added in 
https://issues.apache.org/jira/browse/SAMZA-853 but it is not clear why guava 
is better than default API.
   3. Few code snippets are simplified

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to