dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257425828
########## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSystemConsumer.java ########## @@ -105,6 +106,7 @@ // Overall timeout for EventHubClient exponential backoff policy private static final Duration DEFAULT_EVENTHUB_RECEIVER_TIMEOUT = Duration.ofMinutes(10); + private static final long DEFAULT_INITIALIZE_EVENTHUBSMANAGERS_TIMEOUT_MILLIS = Duration.ofSeconds(15).toMillis(); private static final long DEFAULT_SHUTDOWN_TIMEOUT_MILLIS = Duration.ofSeconds(15).toMillis(); Review comment: On second thought, this timeout is too low; the shutdown is async of all partitions. The `DEFAULT_EVENTHUB_RECEIVER_TIMEOUT` would be a more conservative value. @lhaiesp What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
