shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement
the StartpointVisitor for the KafkaSystemConsumer.
URL: https://github.com/apache/samza/pull/918#discussion_r257522508
##########
File path:
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
##########
@@ -330,6 +387,73 @@ public String getSystemName() {
return systemName;
}
+ @VisibleForTesting
+ static class KafkaStartpointRegistrationHandler implements StartpointVisitor
{
+
+ private final Consumer kafkaConsumer;
+
+ KafkaStartpointRegistrationHandler(Consumer kafkaConsumer) {
+ this.kafkaConsumer = kafkaConsumer;
+ }
+
+ @Override
+ public void visit(SystemStreamPartition systemStreamPartition,
StartpointSpecific startpointSpecific) {
+ TopicPartition topicPartition = toTopicPartition(systemStreamPartition);
+ long offsetInStartpoint =
Long.parseLong(startpointSpecific.getSpecificOffset());
+ LOG.info("Updating the consumer fetch offsets of topic partition: {} to
{}.", topicPartition, offsetInStartpoint);
+
+ // KafkaConsumer is not thread-safe.
+ synchronized (kafkaConsumer) {
+ kafkaConsumer.seek(topicPartition, offsetInStartpoint);
Review comment:
1. Upper layers which call this API already log any exception that is thrown
back.
2. Wrapping the exception to a SamzaException and throwing it back, IMHO
doesn't add much value.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
