mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259947595
########## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala ########## @@ -358,14 +369,6 @@ object SamzaContainer extends Logging { info("Got intermediate streams: %s" format intermediateStreams) - val sideInputStoresToSystemStreams = config.getStoreNames Review comment: Not sure if this is a git diff thing. I notice some usages of `sideInputStoresToSystemStreams` below which are not removed as part of this PR. e.g. ln 546, 567 Can you confirm? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services