rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263553107
########## File path: samza-core/src/main/java/org/apache/samza/storage/TaskSideInputStorageManager.java ########## @@ -74,7 +74,7 @@ private final SystemAdmins systemAdmins; private final TaskName taskName; private final TaskMode taskMode; - private final Map<SystemStreamPartition, String> lastProcessedOffsets = new ConcurrentHashMap<>(); Review comment: Perhaps undo this change. Since this map actually stores the "last processed offset for the given side input" (which is used to emit a metric). SideInputs are only checkpointed locally (see writeOffsetFiles). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
