mynameborat commented on a change in pull request #942: Bugfix: Recent CSM
refactor was causing some metrics to not be emitted. Fixed <task>-restore-time
metric.
URL: https://github.com/apache/samza/pull/942#discussion_r263637333
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -573,6 +576,25 @@ private StorageEngine createStore(String storeName,
TaskName taskName, TaskModel
return
this.sideInputStorageManagers.values().stream().collect(Collectors.toSet());
}
+ /**
+ * Registers any CSM created metrics such as side-inputs related metrics,
and standby-task related metrics.
+ * @param metricsReporters metrics reporters to use
+ */
+ public void registerMetrics(Map<String, MetricsReporter> metricsReporters) {
Review comment:
+1, we would need to change the `SystemConsumerMetrics` to take a
configurable group name instead of using the default class name as the group
id. I feel that change is much simpler compared to copying over the boiler
plate code for metrics registration to CSM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
