xinyuiscool commented on a change in pull request #950: SAMZA-2126: Bug fixes
for batch-mode generated stream specs
URL: https://github.com/apache/samza/pull/950#discussion_r264770420
##########
File path:
samza-core/src/test/java/org/apache/samza/execution/TestStreamEdge.java
##########
@@ -50,8 +50,9 @@ public void testGetStreamSpec_Batch() {
Map<String, String> config = new HashMap<>();
config.put(ApplicationConfig.APP_MODE,
ApplicationConfig.ApplicationMode.BATCH.name());
config.put(ApplicationConfig.APP_RUN_ID, "123");
- StreamEdge edge = new StreamEdge(spec, true, false, new MapConfig(config));
- assertEquals(edge.getStreamSpec().getPhysicalName(),
spec.getPhysicalName() + "-123");
+ StreamSpec batchSpec = new StreamSpec("stream-1", "stream-1", "system-1");
+ StreamEdge edge = new StreamEdge(batchSpec, true, false, new
MapConfig(config));
+ assertEquals(edge.getStreamSpec().getPhysicalName(),
batchSpec.getPhysicalName() + "-123");
Review comment:
Add the case as @lhaiesp mentioned. There is already a existing test for
nonbatch intermediate streams (see the test below this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
