mynameborat commented on a change in pull request #938: SAMZA-1531: Support
run.id in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r263820649
##########
File path:
samza-azure/src/main/java/org/apache/samza/coordinator/AzureCoordinationUtils.java
##########
@@ -52,6 +52,16 @@ public DistributedLockWithState getLockWithState(String
lockId) {
return new AzureLock(blob);
}
+ @Override
+ public DistributedReadWriteLock getReadWriteLock(String lockId) throws
UnsupportedOperationException {
Review comment:
Why do these methods carry explicit exceptions in their signature and return
null? If there is a way forward for applications running in batch mode in the
absence of these primitives, we should throw `UnsupportedOperationException`
and handle it in LJB as opposed to returning a null.
I'd prefer not to return null and have null checks at the callsite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
