shanthoosh commented on a change in pull request #978: SAMZA-1733 : Making
MetricsSnapshotReporter look for appclass then taskclass
URL: https://github.com/apache/samza/pull/978#discussion_r269704869
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
##########
@@ -45,10 +45,8 @@ class MetricsSnapshotReporterFactory extends
MetricsReporterFactory with Logging
val jobId = config
.getJobId
- val taskClass = config
- .getTaskClass
- .orElse(Option(new ApplicationConfig(config).getAppClass()))
- .getOrElse(throw new SamzaException("No task or app class defined for
config."))
+ val taskClass = Option(new ApplicationConfig(config).getAppClass())
Review comment:
>> I dont see any point in logging a warning, since we can't
improve-upon/act-upon it
task.class is deprecated post 1.0. This log-warning is required to
communicate to users that they're using deprecated config in their job.
>> Task.subtask.class is not valid post samza 1.0.
No, it is just deprecated and it is not removed. Couple of high-end
jobs(incl atc, concourse) still use it after 1.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
