[GitHub] [samza] sborya commented on a change in pull request #984: Samza 2116: Making sink, sendTo(table), sendTo(stream) non-terminal

[GitBox]

sborya commented on a change in pull request #984: Samza 2116: Making sink, 
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r271996994
 
 

 ##########
 File path: 
samza-core/src/test/java/org/apache/samza/operators/TestJoinOperator.java
 ##########
 @@ -350,6 +350,7 @@ private StreamApplicationDescriptorImpl 
getTestJoinStreamGraph(TestJoinFunction
             .sink((message, messageCollector, taskCoordinator) -> {
                 SystemStream outputSystemStream = new 
SystemStream("outputSystem", "outputStream");
                 messageCollector.send(new 
OutgoingMessageEnvelope(outputSystemStream, message));
+                return message;
 
 Review comment:
   why do you need to return message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services