kw2542 commented on a change in pull request #79: Update doc and javadoc from config factory to config loader URL: https://github.com/apache/samza-hello-samza/pull/79#discussion_r399576572
########## File path: README.md ########## @@ -61,13 +61,19 @@ Package [samza.examples.cookbook](https://github.com/apache/samza-hello-samza/tr Package [samza.examples.wikipedia.application](https://github.com/apache/samza-hello-samza/tree/master/src/main/java/samza/examples/wikipedia/application) contains a small Samza application which consumes the real-time feeds from Wikipedia, extracts the metadata of the events, and calculates statistics of all edits in a 10-second window. You can start the app on the grid using the run-app.sh script: ``` -./deploy/samza/bin/run-app.sh --config-factory=org.apache.samza.config.factories.PropertiesConfigFactory --config-path=file://$PWD/deploy/samza/config/wikipedia-application.properties +./deploy/samza/bin/run-app.sh \ + --config app.class=samza.examples.wikipedia.application.WikipediaApplication \ + --config yarn.package.path=file:///Users/kwu/workspace/hello-samza/target/hello-samza-1.5.0-SNAPSHOT-dist.tar.gz \ + --config job.name=wikipedia-application \ + --config job.factory.class=org.apache.samza.job.yarn.YarnJobFactory \ Review comment: submission related configs, such as job.name, app.class, job.factory.class and yarn.package.path needs to be explicitly passed in during submission since we are not reading config files anymore during submission. I am cleaning up properties file ATM as well. I believe the previous PR missed the instruction that all submission related configs needs to be provided explicitly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
