kw2542 commented on a change in pull request #79: Update doc and javadoc from config factory to config loader URL: https://github.com/apache/samza-hello-samza/pull/79#discussion_r404501360
########## File path: src/main/config/azure-blob-application.properties ########## @@ -30,10 +30,14 @@ yarn.package.path=file://${basedir}/target/${project.artifactId}-${pom.version}- # StreamApplication class app.class=samza.examples.azure.AzureBlobApplication -#Azure blob essential configs +# Azure blob essential configs systems.azure-blob-container.samza.factory=org.apache.samza.system.azureblob.AzureBlobSystemFactory sensitive.systems.azure-blob-container.azureblob.account.name=your-azure-storage-account-name sensitive.systems.azure-blob-container.azureblob.account.key=your-azure-storage-account-key +# Config Loader +job.config.loader.factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory +job.config.loader.properties.path=./__package/config/azure-blob-application.properties Review comment: Yes, "__package" is Samza's internal implementation detail where localized job to be unzipped at. It is challenging to do it programmatically as clients may or may not include __package in the path, and different programs may have different locations to put their configs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services