malcolm-pro commented on code in PR #87: URL: https://github.com/apache/samza-hello-samza/pull/87#discussion_r1187747914
########## bin/grid: ########## @@ -34,9 +34,10 @@ DEPLOY_ROOT_DIR=$BASE_DIR/deploy DOWNLOAD_CACHE_DIR=$HOME/.samza/download COMMAND=$1 SYSTEM=$2 +YARN_VERSION="3.3.4" Review Comment: Should this be flagged somehow to correspond with the version of Java being used, or maybe intentionally flagged? I believe Samza under Java 8 is still using Hadoop 2.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
