----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14539/#review26779 -----------------------------------------------------------
Ship it! Seems reasonable. Consider breaking the the clock into a seperate class since I think what you want is something like this: https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=blob_plain;f=core/src/test/scala/unit/kafka/utils/MockTime.scala;hb=HEAD where you control the advancement of time manually. This is pretty useful for writing tests. - Jay Kreps On Oct. 8, 2013, 5:11 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14539/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 5:11 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > make blocking envelope map test inject a clock so clock times are predictable. > > > Diffs > ----- > > samza-api/src/test/java/org/apache/samza/util/TestBlockingEnvelopeMap.java > 62152d02014a93345b442eab228d892d7cb37d9f > > Diff: https://reviews.apache.org/r/14539/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
