> On Oct. 23, 2013, 5:54 p.m., Sriram Subramanian wrote: > > You want to retry for all types of errors?
Good point. Looking at possible codes: RETRY: val UnknownCode : Short = -1 OK: val NoError : Short = 0 NOT VALID: val OffsetOutOfRangeCode : Short = 1 FAIL: val InvalidMessageCode : Short = 2 RETRY: val UnknownTopicOrPartitionCode : Short = 3 NOT VALID: val InvalidFetchSizeCode : Short = 4 RETRY: val LeaderNotAvailableCode : Short = 5 RETRY: val NotLeaderForPartitionCode : Short = 6 RETRY: val RequestTimedOutCode: Short = 7 RETRY: val BrokerNotAvailableCode: Short = 8 RETRY: val ReplicaNotAvailableCode: Short = 9 NOT VALID: val MessageSizeTooLargeCode: Short = 10 RETRY: val StaleControllerEpochCode: Short = 11 It seems like the only one where it makes sense to fully fail is when there's an invalid message code. Debatable whether to retry on unknown code. Perhaps some are recoverable and some aren't? - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14878/#review27387 ----------------------------------------------------------- On Oct. 23, 2013, 5:34 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14878/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 5:34 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > check error mapping for offset response in kafka checkpoint manager > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > a9ddc5ce5973f8c05630d7fd5702c99be6b62182 > > Diff: https://reviews.apache.org/r/14878/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
