----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15104/#review27832 -----------------------------------------------------------
Ship it! Ship It! - Sriram Subramanian On Oct. 30, 2013, 8:53 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15104/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 8:53 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > setting a container name for the am now. cleaned up some environment variable > names. removed yarnconfig environment variables in favor of shell command > builder. added system properties for container name and log directory in > run-clas.sh. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala > fd8dab8c1b854ad218e97f5401742e1a6e3fc70a > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 6337a2a73b94eaa7a8790c30df891b664990d208 > samza-core/src/main/scala/org/apache/samza/job/ShellCommandBuilder.scala > f55ca4cdee8b84f060f8905c467cf2822cf7be25 > samza-shell/src/main/bash/run-class.sh > e91bf993e7ccda65c335f382ef84af73bfa6bbdf > samza-yarn/src/main/scala/org/apache/samza/config/YarnConfig.scala > 4779edb5b77d05833cbeb93b11ca80e8f23f08dc > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala > 6d72d8670bf5a74b22227cd17b82326f9c094677 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > 51097c1694ab7e1197ba5c9ef3e280898918bf99 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala > 3f0339939acade79f58aa571ab1dc130eb20b5b1 > > Diff: https://reviews.apache.org/r/15104/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
