----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15900/#review29647 -----------------------------------------------------------
Ship it! Ship It! samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala <https://reviews.apache.org/r/15900/#comment57061> Not directly related to this patch, but wouldn't an implicit conversion work here? - Jakob Homan On Nov. 27, 2013, 8:44 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15900/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 8:44 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > clean up random read write remove test > > > add tests for SAMZA-80. Handle null-prev bug. Add a sanity check that just > uses the store for a while, and validates that it works as expected. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala > b412e46c5478549a771ba0b1a1b3620d6303958c > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala > 6685f8534fccf03bb3a139f16e1b35596c7894c8 > > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > 03a189e71191af364aaec21baf5876c683cbf782 > > Diff: https://reviews.apache.org/r/15900/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
