----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16430/#review31069 -----------------------------------------------------------
build.gradle <https://reviews.apache.org/r/16430/#comment59409> Any reason not to forward all the properties? I can see some test in the future needing something and confusing the test writer as to why it's not appearing. Minor. samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala <https://reviews.apache.org/r/16430/#comment59417> Needs ASF header. - Jakob Homan On Dec. 20, 2013, 3:47 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16430/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 3:47 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > fix some docs in perf test. fix scala 2.8.1 compile issue related to adding > ints in SystemConsumers. revert accidental reviewboardrc checkin. > > > adding one extra doc to build.gradle > > > adding javadocs everywhere > > > adding caching for system fetch map in SystemConsumers.poll > > > bump up heap for performance test. > > > move samza core to compile time dependency since mock system uses it. > > > add mock system and test for performance. > > > Diffs > ----- > > .reviewboardrc 0ee6a71c84942b7a626ce66994e4abfcb87bf4c8 > build.gradle 49a8459c43102b597c69ba6d7e0262baf843b513 > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala > 5cbffe5fdf9dd60d0b76aa88ab0fef09addb4e31 > samza-test/java.hprof.txt c5693d20c2caa471f164b7cb05d0c32eee9e3b03 > samza-test/src/main/java/org/apache/samza/system/mock/MockSystemAdmin.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/system/mock/MockSystemConsumer.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/system/mock/MockSystemFactory.java > PRE-CREATION > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 9602a527a8fdbc8e342413eeb62d1aef27b1972d > > samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/16430/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
