Thanks for this Chris and for being patient whilst I navigate Scala. I am still trying to work out exactly if it fits the OO or functional paradigm more.
-S -------- Original message -------- From: Chris Riccomini <[email protected]> Date: To: Steven Yates <[email protected]> Cc: samza <[email protected]>,Chris Riccomini <[email protected]> Subject: Re: Review Request 17705: SAMZA-96 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17705/#review33703 ----------------------------------------------------------- Few minor nits. Also, could you post the patch to JIRA as well? samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala <https://reviews.apache.org/r/17705/#comment63301> Move outside the class, to top level object. Rename object to be a companion for JvmMetrics. That is, "object JvmMetrics { ..prefix constant } Then do import MetricsSnapshotReporter._ in the class. samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala <https://reviews.apache.org/r/17705/#comment63300> Move outside the class, to top level object. Rename object to be a companion for MetricsSnapshotReporter. That is, "object MetricsSnapshotReporter { ..prefix constant } Then do import MetricsSnapshotReporter._ in the class. samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala <https://reviews.apache.org/r/17705/#comment63299> Prefer constant here, like other ones. - Chris Riccomini On Feb. 5, 2014, 11:38 a.m., Steven Yates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17705/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 11:38 a.m.) > > > Review request for samza and Steven Yates. > > > Bugs: SAMZA-96 > https://issues.apache.org/jira/browse/SAMZA-96 > > > Repository: samza > > > Description > ------- > > Review request for SAMZA-96 > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala 301a5a0 > >samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala > 15af7aa > samza-core/src/main/scala/org/apache/samza/util/DaemonThreadFactory.scala >04e67a2 > >samza-core/src/test/scala/org/apache/samza/util/TestDaemonThreadFactory.scala >PRE-CREATION > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala >89730db > > Diff: https://reviews.apache.org/r/17705/diff/ > > > Testing > ------- > > Unit test TestDaemonThreadFactory.scala > > > Thanks, > > Steven Yates > >
