Github user ept commented on a diff in the pull request:
https://github.com/apache/incubator-samza/pull/1#discussion_r9885664
--- Diff:
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala
---
@@ -27,17 +27,32 @@ import java.io._
import java.util.Iterator
import java.lang.Iterable
import org.apache.samza.config.Config
-import grizzled.slf4j.Logging
+import org.apache.samza.container.SamzaContainerContext
+import grizzled.slf4j.{Logger, Logging}
object LevelDbKeyValueStore {
- def options(config: Config) = {
+ private lazy val logger = Logger(classOf[LevelDbKeyValueStore])
+
+ def options(config: Config, containerContext: SamzaContainerContext) = {
--- End diff --
I also got caught out by that one. The config here isn't the entire job
config, but only the subset of the config for that particular store -- so if we
don't pass in that subset config, we'd still have to at least pass in the store
name so that LevelDbKeyValueStore knows which store we're talking about. I
thought it would be better to continue passing in the subset of the config
instead.
Perhaps we should call the parameter `storeConfig` to prevent such
confusion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
