-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18606/#review36516
-----------------------------------------------------------
I was wondering, rather than changing all those "catch { case _ =>" occurrences
to catch Throwable, wouldn't it be better to change them to catch Exception
instead? I just got caught out by a "catch Throwable", which was catching
scala.runtime.NonLocalReturnControl (which is Throwable but not an Exception).
NonLocalReturnControl is used internally by Scala for unusual flow control in
some cases, such as jumping out of nested closures (I think). It's not
something that normal code should be catching.
- Martin Kleppmann
On March 1, 2014, 1:19 a.m., Jakob Homan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18606/
> -----------------------------------------------------------
>
> (Updated March 1, 2014, 1:19 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-161
> https://issues.apache.org/jira/browse/SAMZA-161
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-161
>
>
> Diffs
> -----
>
> build.gradle 31c54be
> gradle/dependency-versions-scala-2.10.gradle 47de65a
> gradle/dependency-versions-scala-2.9.2.gradle e7b56a6
> gradle/license.gradle b4b62eb
>
> samza-core/src/main/scala/org/apache/samza/config/DefaultChooserConfig.scala
> 9351c66
>
> samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala
> 0d82183
> samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
> dfa3cd7
> samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 60c9615
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala
> 0d71582
>
> samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaSerdeConfig.scala
> 2e7459e
>
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala
> 2a74ea5
>
> samza-test/src/main/java/org/apache/samza/test/integration/SimpleStatefulTask.java
> 973b0ba
>
> samza-test/src/main/java/org/apache/samza/test/integration/StatePerfTestTask.java
> 873de74
>
> samza-test/src/main/java/org/apache/samza/test/integration/join/Checker.java
> 22f5e87
>
> samza-test/src/main/java/org/apache/samza/test/integration/join/Emitter.java
> 2989ca7
>
> samza-test/src/main/java/org/apache/samza/test/integration/join/EpochPartitioner.java
> d11d300
> samza-test/src/main/java/org/apache/samza/test/integration/join/Joiner.java
> ca8fed4
>
> samza-test/src/main/java/org/apache/samza/test/integration/join/Watcher.java
> fac4ee1
> samza-test/src/main/resources/common.properties 971a219
> samza-test/src/main/resources/hello-stateful-world.samsa 84325d0
> samza-test/src/main/resources/join/checker.samsa e41ffa0
> samza-test/src/main/resources/join/emitter.samsa 140d13d
> samza-test/src/main/resources/join/joiner.samsa 27655d8
> samza-test/src/main/resources/join/watcher.samsa a4cc761
> samza-test/src/main/resources/log4j.xml ecaf8a2
> samza-test/src/main/resources/perf/counter.samsa cf06c9e
>
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala
> b24f85a
>
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
> 3064c86
>
> Diff: https://reviews.apache.org/r/18606/diff/
>
>
> Testing
> -------
>
> Unit tests
>
>
> Thanks,
>
> Jakob Homan
>
>
