----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18986/#review37260 -----------------------------------------------------------
Ship it! Ship It! - Jakob Homan On March 14, 2014, 10:53 a.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18986/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 10:53 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > add test for GetOffset to validate that empty message sets don't throw > exceptions. add test for offsetmanager to fix npe. > > > remove empty message set check since it doesn't work with upcoming offsets. > fix log wording in offsetmanager to say upcoming instead of newest > > > initial patch application > > > Diffs > ----- > > samza-api/src/main/java/org/apache/samza/system/SystemAdmin.java > 437bfb2bb6f84728df7e51066618d4df4e321b02 > samza-api/src/main/java/org/apache/samza/system/SystemStreamMetadata.java > 32e142a5edbffe2fe68ea9a4c9172e0f0db54922 > > samza-api/src/main/java/org/apache/samza/util/SinglePartitionWithoutOffsetsSystemAdmin.java > 44fd82a94b82ca12aa02b650e054cfd87848409b > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala > 517e9ae3572b64eacad3e7c123366033ab436230 > samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala > ce63a8aa3831ee18132a58d7b746853f181407c3 > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 9c2324473c632a630f85d2f4c822d601997cdc1b > samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala > 512759591c17e154c7f2dec899a444f7adcb40d5 > > samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala > f7d3c8bb5cca28e501abe4ff07111f262bfbea74 > > samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala > PRE-CREATION > samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala > 5e9dd0727291070481b2221c2a125c4ba7d8a4e7 > samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala > dcc71c4aba28523d125582df34526449878783ca > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala > 53255490dfbcd926a0d9975415ce437f01c29264 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestGetOffset.scala > PRE-CREATION > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala > eaa9e53db0b641e16b4eafe2be89ae6d7b4e5384 > samza-test/src/main/java/org/apache/samza/system/mock/MockSystemAdmin.java > 2abe1c84ca59d4c67d0bf2bbd253ece2ea643fe8 > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 7e813870ef07cee889d3be526d62f4e7574ce100 > > Diff: https://reviews.apache.org/r/18986/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
