> On March 21, 2014, 3:29 a.m., Chris Riccomini wrote: > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala, > > line 209 > > <https://reviews.apache.org/r/19512/diff/1/?file=531002#file531002line209> > > > > We're doing brackets on single line if statements in Samza... much to > > Jay's dismay. :)
Ack, I have to remove my Kafka hat to swallow that :) - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19512/#review38042 ----------------------------------------------------------- On March 21, 2014, 2:09 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19512/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 2:09 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-193 > https://issues.apache.org/jira/browse/SAMZA-193 > > > Repository: samza > > > Description > ------- > > Minor fix to the KafkaCheckpointManager to check for a valid producer before > stopping it > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > a1d2ffe > > Diff: https://reviews.apache.org/r/19512/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
