----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20022/#review40687 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/system/MessageChooserBuffer.scala <https://reviews.apache.org/r/20022/#comment73784> This class effectively wraps the chooser. Would it be better extending Chooser, ie BufferingMessageChooser? samza-core/src/main/scala/org/apache/samza/system/MessageChooserBuffer.scala <https://reviews.apache.org/r/20022/#comment73787> Can we add return types to aid in readability? samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala <https://reviews.apache.org/r/20022/#comment73779> Typo: this -> thus samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala <https://reviews.apache.org/r/20022/#comment73781> This in combination with depletedQueueSizeThreshold is confusing. - Jakob Homan On April 17, 2014, 10:30 a.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20022/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 10:30 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > move coordinator to buffer, and add javadocs > > > move unprocessed messages into coordinator > > > adding a message chooser coordinator to try and extract some of the confusing > logic from system consumers into a separate class > > > don't hard code the refresh threshold > > > bump default max msgs per stream partition up to 10k > > > add an unprocessed message counter > > > black list empty system stream partitions > > > Diffs > ----- > > > samza-core/src/main/scala/org/apache/samza/system/MessageChooserBuffer.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala > bbbacb59866c2374853052f7cc11826552f5fb01 > > Diff: https://reviews.apache.org/r/20022/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
