----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20697/#review41514 -----------------------------------------------------------
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala <https://reviews.apache.org/r/20697/#comment74962> Can we move this into its own test for cleaner reporting? samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala <https://reviews.apache.org/r/20697/#comment74963> We need to catch _ here and fail as well. Otherwise some problem could happen in register but this would silently swallow it. Alternatively, the var caughtRightException = false try { blah } catch { case e: caughtRightException = true } assertTrue(caughtRightException) pattern will catch this as well. - Jakob Homan On April 24, 2014, 6:07 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20697/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 6:07 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fail early when a consumer is misconfigured. > > 1. wraped the consumer register with try and catch > 2. added SystemConsumerException extends SamzaException > 3. added test for checking throwing the correct exception > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala > 7624aef > samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala > e1b211d > > Diff: https://reviews.apache.org/r/20697/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
