-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20811/
-----------------------------------------------------------

(Updated April 29, 2014, 10:37 p.m.)


Review request for samza.


Repository: samza


Description (updated)
-------

add license header to new files


updating perf test to use delete threshold setting


disable this feature by default


default the delete compaction threshold to cache size


move performance test into samza-test


add javadocs, and reset deletion counter in compact


make delete threshold configurable. add a performance test (takes 25s to run).


make compaction lazy on read-side so we can take advantage of cached writes


trigger compactions periodically to remove deleted keys from levels


Diffs (updated)
-----

  README.md a930cf020c46a616f4c7319881dbff3043b0fd49 
  build.gradle 65d95d4c6eb220b617dab6ea5772c9062ab146bd 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala
 81fe86165019f72a15be1ac9cfcfff0598b4b92b 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 
8602a328673e6fa7d435366abcd9a96a99d9cd88 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 
85ba11a3362ad7cf4f84fbcbd944cd790e572cbe 
  samza-test/src/main/resources/perf/kv-perf.properties PRE-CREATION 
  
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala
 PRE-CREATION 

Diff: https://reviews.apache.org/r/20811/diff/


Testing
-------


Thanks,

Chris Riccomini

Reply via email to