-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22382/#review45121
-----------------------------------------------------------



docs/_layouts/default.html
<https://reviews.apache.org/r/22382/#comment79784>

    Might be safer to put the comment after the <!DOCTYPE>. (I think it is 
technically valid to have a comment before the doctype declaration, but not 
sure if all browsers handle it correctly)



docs/sitemap.xml
<https://reviews.apache.org/r/22382/#comment79783>

    This one probably needs to come after the YAML front matter, and after the 
<?xml?> processing instruction.


- Martin Kleppmann


On June 9, 2014, 5:26 p.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22382/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 5:26 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-92
>     https://issues.apache.org/jira/browse/SAMZA-92
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> More headers
> 
> 
> Diffs
> -----
> 
>   build.gradle 1a1db16 
>   docs/Makefile 93a1a39 
>   docs/README.md 0c1d55c 
>   docs/_config.yml bc84c84 
>   docs/_layouts/default.html 7ae7231 
>   docs/_layouts/page.html 007adf9 
>   docs/_tools/generate-javadocs.sh 0a2e430 
>   docs/_tools/publish-site.sh 285c9e7 
>   docs/community/committers.md bbc0a60 
>   docs/community/irc.md ac191e5 
>   docs/community/mailing-lists.md fa2748d 
>   docs/contribute/code.md 4b25f59 
>   docs/contribute/coding-guide.md cdcb0ea 
>   docs/contribute/disclaimer.md 3fe446f 
>   docs/contribute/projects.md ee1932d 
>   docs/contribute/rules.md 5644b6a 
>   docs/contribute/seps.md 71342fd 
>   docs/index.md a070089 
>   docs/learn/documentation/0.7.0/api/overview.md 2d03ec3 
>   docs/learn/documentation/0.7.0/comparisons/introduction.md 77c04ca 
>   docs/learn/documentation/0.7.0/comparisons/mupd8.md 78e7b64 
>   docs/learn/documentation/0.7.0/comparisons/storm.md 379dc31 
>   docs/learn/documentation/0.7.0/container/checkpointing.md 42b2e8d 
>   docs/learn/documentation/0.7.0/container/event-loop.md 1f9c51e 
>   docs/learn/documentation/0.7.0/container/index.md 17751de 
>   docs/learn/documentation/0.7.0/container/jmx.md a9fcc77 
>   docs/learn/documentation/0.7.0/container/metrics.md 078ce47 
>   docs/learn/documentation/0.7.0/container/state-management.md aa418ff 
>   docs/learn/documentation/0.7.0/container/streams.md 0f18b34 
>   docs/learn/documentation/0.7.0/container/task-runner.md bdc5ab6 
>   docs/learn/documentation/0.7.0/container/windowing.md 6a24378 
>   docs/learn/documentation/0.7.0/index.html a3f0c7f 
>   docs/learn/documentation/0.7.0/introduction/architecture.md c4e0fc9 
>   docs/learn/documentation/0.7.0/introduction/background.md 87717e5 
>   docs/learn/documentation/0.7.0/introduction/concepts.md 76012e2 
>   docs/learn/documentation/0.7.0/jobs/configuration-table.html 8b42b3a 
>   docs/learn/documentation/0.7.0/jobs/configuration.md d4a516e 
>   docs/learn/documentation/0.7.0/jobs/job-runner.md c73b234 
>   docs/learn/documentation/0.7.0/jobs/logging.md 6bb6bf4 
>   docs/learn/documentation/0.7.0/jobs/packaging.md 62c089a 
>   docs/learn/documentation/0.7.0/jobs/yarn-jobs.md 3d971cd 
>   docs/learn/documentation/0.7.0/operations/kafka.md 8bb1a44 
>   docs/learn/documentation/0.7.0/operations/security.md 55a7f11 
>   docs/learn/documentation/0.7.0/yarn/application-master.md 0da6dc0 
>   docs/learn/documentation/0.7.0/yarn/isolation.md c685729 
>   docs/learn/tutorials/0.7.0/deploy-samza-job-from-hdfs.md ca5f599 
>   docs/learn/tutorials/0.7.0/index.md 5822cce 
>   docs/learn/tutorials/0.7.0/remote-debugging-samza.md e82e436 
>   docs/learn/tutorials/0.7.0/run-hello-samza-without-internet.md f7a0c1b 
>   docs/learn/tutorials/0.7.0/run-in-multi-node-yarn.md f47953a 
>   docs/sitemap.xml 7c7b269 
>   gradle.properties 3a3ee25 
>   gradle/buildscript.gradle aa29cc4 
>   gradle/dependency-versions-scala-2.10.gradle 2a3632d 
>   gradle/dependency-versions-scala-2.9.2.gradle 7ec296f 
>   gradle/dependency-versions.gradle e50ed40 
>   gradle/environment.gradle 07541c4 
>   gradle/license.gradle ca504e4 
>   gradle/maven.gradle fd54fad 
>   settings.gradle 9e7a4ea 
> 
> Diff: https://reviews.apache.org/r/22382/diff/
> 
> 
> Testing
> -------
> 
> Compiles, looked at web page output.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>

Reply via email to