----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22335/#review45162 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/util/Util.scala <https://reviews.apache.org/r/22335/#comment79854> Does this logic work for windows/linux/mac? Not sure this gives us any advantage over just returning the raw getName results. True it's not a PID, but I think this might be OK, and maybe a bit safer than doing the @ split, and potentially breaking platform support for other random OS's that might format things differently. - Chris Riccomini On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22335/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 11:44 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-192; container PID is logged in SamzaContainer. A new > Util.getContainerPID function returns the PID > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > bfff2a6 > samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd > > Diff: https://reviews.apache.org/r/22335/diff/ > > > Testing > ------- > > I've tried the function in the debugger and the scala interpreter. Could not > try it in a different environemnt than Linux > > > Thanks, > > Raul Castro Fernandez > >
