----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22845/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- 1. added an environment variable SAMZA_LOG4J_FILE in each script. and run-class.sh use that variable for log4j configuration instead of directly pointing to the position of log4j.xml. 2. added log4j-default.xml, which append the logs to console. run-job, kill-yarn-job and checkpoint scripts use this configuration. 3. changed the build.gradle to contain the new log4j-default.xml Diffs ----- build.gradle 1bbd5ca samza-shell/src/main/bash/checkpoint-tool.sh 1a455df samza-shell/src/main/bash/kill-yarn-job.sh 924aac6 samza-shell/src/main/bash/run-am.sh c202596 samza-shell/src/main/bash/run-class.sh cc341b7 samza-shell/src/main/bash/run-container.sh 72cee18 samza-shell/src/main/bash/run-job.sh 0605994 samza-shell/src/main/resources/log4j-default.xml PRE-CREATION Diff: https://reviews.apache.org/r/22845/diff/ Testing ------- Thanks, Yan Fang
