> On June 20, 2014, 5:40 a.m., Yan Fang wrote: > > docs/README.md, line 26 > > <https://reviews.apache.org/r/22748/diff/1/?file=612453#file612453line26> > > > > Is "bundle exec" needed? After installed, we can directly run jekyll.
It is necessary in order to enforce the version constraint. If you just run "jekyll", Rubygems will by default use the latest version of all dependencies that you have installed (whether or not it matches the constraints in the Gemfile). If you run "bundle exec jekyll", it will use the exact versions that were fixed in Gemfile.lock, and tell you to install them if they aren't already. > On June 20, 2014, 5:40 a.m., Yan Fang wrote: > > docs/README.md, line 22 > > <https://reviews.apache.org/r/22748/diff/1/?file=612453#file612453line22> > > > > add something like "go to docs directory"? Otherwise, it can not > > install. Good point, I've updated the README to make this clearer. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22748/#review46256 ----------------------------------------------------------- On June 18, 2014, 6:37 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22748/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 6:37 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-297: Fix the version of Jekyll (and deps) for building docs. > > > Diffs > ----- > > docs/Gemfile PRE-CREATION > docs/Gemfile.lock PRE-CREATION > docs/README.md 0edd84e8931eea4f38be7bcc9824f78d51652292 > docs/_config.yml 9ffb45c62196932081381660792033db58e5f5ff > > Diff: https://reviews.apache.org/r/22748/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
