----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23372/ -----------------------------------------------------------
(Updated July 10, 2014, 6:46 p.m.) Review request for samza. Repository: samza Description (updated) ------- SAMZA-256: Review comments (2) : Merging LevelDb and KeyValue StorageEngine factories SAMZA-256: Addressing review comments SAMZA-256: Adding missing KeyValueStorageEngineFactory.scala SAMZA-256: Provide in-memory data store implementation Diffs (updated) ----- build.gradle c853fc067ab4d23d9fb215b349b8e7f3ca1c4dad gradle/dependency-versions.gradle 078725806f5d41066c6f6a63885d4f6acce8d23c samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala PRE-CREATION samza-kv-leveldb/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStorageEngineFactory.scala PRE-CREATION samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala PRE-CREATION samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 429f51a4d269e3d18627c183359af672c68b8b00 samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStoreMetrics.scala 8ffcfb194b981a798fd19b05f9e6bff9fc2f79e2 samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala f42ea026cd4a2ae633d71149af6dacef68dab352 samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala 36b7e97b427d3d0fd18f38609e2dac2b081a8dbc samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineMetrics.scala a7958f62582a2cc998f026c6818afd24936d46d4 samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 72562cfcaccb99e35f84df87045271473bd82b04 samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStoreMetrics.scala 8949f2fb6d8488e5e061139299e9ea97220ea180 samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStoreMetrics.scala 8949f2fb6d8488e5e061139299e9ea97220ea180 samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStoreMetrics.scala 8949f2fb6d8488e5e061139299e9ea97220ea180 samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala d3c1ae84b56827964ce10d2aa9dedcdc7221c596 samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStoreMetrics.scala ea56e8c2e41efa0c59bedac9e489b399fc8813e4 samza-kv/src/main/scala/org/apache/samza/storage/kv/NullSafeKeyValueStore.scala 00f9af319c780d9513b735016b1c3e016714f5c8 samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 2d3b6e55c20172aa5f149c6d6728cab8229312c3 samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStoreMetrics.scala 2ad21c822f3d9c08dcc1e78d4b86c3fd314b7ed2 samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 4856be0a92c6c50cfee800e659cad9cc7b05f4d5 samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 0077af08ac33bd95b1d40c362f95dfd6208cf99c settings.gradle 6ba628059a3168abf80d072d68942f79bd237811 Diff: https://reviews.apache.org/r/23372/diff/ Testing ------- Thanks, Chinmay Soman
