-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24011/
-----------------------------------------------------------

(Updated July 29, 2014, 11:15 p.m.)


Review request for samza.


Bugs: SAMZA-109
    https://issues.apache.org/jira/browse/SAMZA-109


Repository: samza


Description (updated)
-------

SAMZA-109: Fixing ThreadJobFactory after the rebase


SAMZA-109: Addressing review comments


Modifying run-class.sh to add standard flags to user specified JVM_OPTS


SAMZA:109 Make task.opts easier to use


Diffs (updated)
-----

  docs/learn/documentation/0.7.0/jobs/configuration-table.html 
41f334f20ce88b425bcbda861c6ff5bd9194b8a8 
  docs/learn/documentation/0.7.0/jobs/configuration.md 
2ed3ea7d9d7e4aad92f5f077cf434a7eaa9a2cba 
  docs/learn/documentation/0.7.0/jobs/job-runner.md 
55c91144e5d8af2415a75dcf76f9d464fa920eb0 
  docs/learn/documentation/0.7.0/jobs/packaging.md 
f888f7537bc47ee1de7bcc135bcc1bfa6b140628 
  samza-core/src/main/scala/org/apache/samza/job/local/LocalJobFactory.scala 
713bded5e53190f546d11ca66c0953028337e68d 
  samza-core/src/main/scala/org/apache/samza/job/local/LocalJobFactory.scala 
713bded5e53190f546d11ca66c0953028337e68d 
  samza-shell/src/main/bash/run-am.sh 878d938329ee0956b8261aee35f73a31111a5223 
  samza-shell/src/main/bash/run-class.sh 
a75cbb915659dcf69febe5bc91999225aa21971f 
  samza-shell/src/main/bash/run-container.sh 
b43bc3f7e6d7d3df7b3edd8e910f5ac9de548295 
  samza-test/src/main/resources/hello-stateful-world.samsa 
8c2f2e47f77549a772d7d8d7cf922f7bfd1112b6 
  
samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala
 3ed8b5cc841f592b8d9bc8007ce04720825b3634 
  
samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala
 1f4c247e7a9918695619fd236c9ed4950ddbc967 

Diff: https://reviews.apache.org/r/24011/diff/


Testing
-------

Manual testing done by adding the following config to wikipedia-feed.properties 
(in hello-samza):

task.opts=-Xmx600M


(For both Yarn and Process JobFactory).

The resulting config had this user property as well as all the other standard 
flags in JVM_OPTS: (GC related flags, log directory)


Thanks,

Chinmay Soman

Reply via email to