-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24141/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 4:54 p.m.)
Review request for samza.
Changes
-------
1. removed the redundant Clock class. create anonymous class when use the Clock
2. added another constructor in SlidingTimeWindowReservoir
3. added _MS
4. updated MetricsRegistry. And accordingly, updated classes that inherit
MetricsRegistry.
Passed all unit tests.
Bugs: SAMZA-349
https://issues.apache.org/jira/browse/SAMZA-349
Repository: samza
Description
-------
Add a Timer metric.
1) Created Timer.class that uses Reservoir.class to store time durations.
2) Created Reservoir interface, which is to store different values.
3) Created SlidingTimeWindowReservoir. It removes values that are out of date.
Use this as the default reservoir for the Timer.
4) Created Snapshot class to report the max/min/average in Reservoir.
5) Updated MetricsVisitor by adding Timer
6) Updated relevant classes that uses MetricsVisitor: JmxReporter.scala,
MetricsSnapshotReporter.scala and ApplicationMasterRestServlet.scala
7) Unit tests
Diffs (updated)
-----
build.gradle 3ad5fe3
samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 1031e45
samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java f4f756a
samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistryListener.java
a16378f
samza-api/src/main/java/org/apache/samza/metrics/Reservoir.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java
PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/Snapshot.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/Timer.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java
d7bc4a9
samza-api/src/test/java/org/apache/samza/metrics/TestSlidingTimeWindowReservoir.java
PRE-CREATION
samza-api/src/test/java/org/apache/samza/metrics/TestSnapshot.java
PRE-CREATION
samza-api/src/test/java/org/apache/samza/metrics/TestTimer.java PRE-CREATION
samza-api/src/test/java/org/apache/samza/util/TestNoOpMetricsRegistry.java
78d2824
samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala
8043f37
samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala
da83f20
samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala
8814e68
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala
9a56754
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
d10dc38
Diff: https://reviews.apache.org/r/24141/diff/
Testing
-------
Thanks,
Yan Fang
