----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24750/#review50787 -----------------------------------------------------------
docs/_layouts/default.html <https://reviews.apache.org/r/24750/#comment88653> Should we only execute this code if pageurl containers versioned? Otherwise, it seems like the call is made on every page load, even for unversioned pages. - Chris Riccomini On Aug. 15, 2014, 10:10 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24750/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 10:10 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-383 > https://issues.apache.org/jira/browse/SAMZA-383 > > > Repository: samza > > > Description > ------- > > only display the switch-version-button when the link is available. > > 1. added the jquery link the default.html > 2. added a function to check the url existence > 3. only do the check after the page is ready > > > Diffs > ----- > > docs/_layouts/default.html e0438b8 > > Diff: https://reviews.apache.org/r/24750/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
