Ah..ok :) Navina
On 11/21/14, 10:53 AM, "Chris Riccomini" <[email protected]> wrote: >Hey Navina, > >I agree. I think people are misunderstanding this patch. I want to do two >things: > >1. Force all serdes with any outside dependencies into their own package >(e.g. samza-serializers-avro). >2. Allow serdes with no new dependencies into samza-core. >3. Eliminate the general samza-serializers package in favor of more >specific per-serializer packages (samza-serializers-avro, etc). > >Cheers, >Chris > >On 11/21/14 10:51 AM, "Navina Ramesh" <[email protected]> wrote: > >>Ok. I just think it is much cleaner to keep the serializers in their own >>separate project, because often I have noticed they pull in many >>dependencies. It seems much cleaner to leave them in a separate project >>as >>it is today. My 2 cents. >> >>Cheers, >>Navina >> >>On 11/21/14, 10:44 AM, "Chris Riccomini" <[email protected]> wrote: >> >>>Hey Navina, >>> >>>No one is working on it, that I know of. There is a ticket open for >>>Avro, >>>though: >>> >>>https://issues.apache.org/jira/browse/SAMZA-317 >>> >>> >>>Cheers, >>>Chris >>> >>>On 11/21/14 10:41 AM, "Navina Ramesh" <[email protected]> wrote: >>> >>>> >>>>----------------------------------------------------------- >>>>This is an automatically generated e-mail. To reply, visit: >>>>https://reviews.apache.org/r/28337/#review62587 >>>>----------------------------------------------------------- >>>> >>>> >>>>Quick question: going forward, are we planning to add support for avro >>>>and/or protobuf ? >>>> >>>>- Navina Ramesh >>>> >>>> >>>>On Nov. 21, 2014, 6:19 p.m., Chris Riccomini wrote: >>>>> >>>>> ----------------------------------------------------------- >>>>> This is an automatically generated e-mail. To reply, visit: >>>>> https://reviews.apache.org/r/28337/ >>>>> ----------------------------------------------------------- >>>>> >>>>> (Updated Nov. 21, 2014, 6:19 p.m.) >>>>> >>>>> >>>>> Review request for samza. >>>>> >>>>> >>>>> Bugs: SAMZA-473 >>>>> https://issues.apache.org/jira/browse/SAMZA-473 >>>>> >>>>> >>>>> Repository: samza >>>>> >>>>> >>>>> Description >>>>> ------- >>>>> >>>>> update docs >>>>> >>>>> >>>>> remove samza-serializers >>>>> >>>>> >>>>> Diffs >>>>> ----- >>>>> >>>>> build.gradle 772d16231471b76a0897378de306e81b2c78d54a >>>>> docs/learn/documentation/versioned/container/serialization.md >>>>>ff7d8b97a02a94fa4370ecdfb114f316f4fe008d >>>>> >>>>>samza-serializers/src/main/scala/org/apache/samza/serializers/JsonSerd >>>>>e >>>>>. >>>>>s >>>>>cala >>>>> >>>>>samza-serializers/src/main/scala/org/apache/samza/serializers/MetricsS >>>>>n >>>>>a >>>>>p >>>>>shotSerde.scala >>>>> >>>>>samza-serializers/src/test/scala/org/apache/samza/serializers/TestJson >>>>>S >>>>>e >>>>>r >>>>>de.scala >>>>> >>>>>samza-serializers/src/test/scala/org/apache/samza/serializers/TestMetr >>>>>i >>>>>c >>>>>s >>>>>SnapshotSerde.scala >>>>> settings.gradle 216c5ee5544a76b0ec7578bf94ebe3e2ce25a551 >>>>> >>>>> Diff: https://reviews.apache.org/r/28337/diff/ >>>>> >>>>> >>>>> Testing >>>>> ------- >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Chris Riccomini >>>>> >>>>> >>>> >>> >> >
