Hey Martin, Good catch. Comments on:
https://issues.apache.org/jira/browse/SAMZA-226?focusedCommentId=14224770&p age=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#commen t-14224770 Summary: I think we should revert this patch and do a new 0.8.0 RC without it. Cheers, Chris On 11/25/14 3:10 AM, "Martin Kleppmann" <[email protected]> wrote: >After looking at SAMZA-226 in more detail, I'm afraid I'm going to vote >-1 on 0.8.0-RC0. See my comments on Jira and RB for reasoning. Especially >the configuration bug: if we fix that in a follow-on release, it would be >a backwards-incompatible change (requiring people to update their >configs). > >We should either fix SAMZA-226 and do it properly for 0.8.0, or revert >that patch and include a fixed version in a follow-on 0.8.1 release. > >Martin > >On 25 Nov 2014, at 00:11, Martin Kleppmann <[email protected]> wrote: > >> Verified pgp signature and md5, verified license, built from source >>using JDK7, ran tests, built hello-samza against RC and ran it. The >>first two stages of hello-samza work, but the third one (which uses a >>changelog stream) won't start up due to SAMZA-226. Is that a known >>problem? >> >> Note: build fails on JDK8 (compile-time errors when building for Scala >>2.9.2, and samza-kafka test hangs when building for Scala 2.10). I think >>it would be worth pointing out in the README that you need to use JDK7. >>However, I don't think we need to roll a new RC just because of that. >> >> Martin >> >> On 24 Nov 2014, at 22:15, Shekar Tippur <[email protected]> wrote: >> >>> +1 >>> >>> On Mon, Nov 24, 2014 at 2:11 PM, Jay Kreps <[email protected]> wrote: >>> >>>> +1 >>>> >>>> -Jay >>>> >>>> On Thu, Nov 20, 2014 at 4:17 PM, Chris Riccomini < >>>> [email protected]> wrote: >>>> >>>>> Hey all, >>>>> >>>>> This is a call for a vote on a release of Apache Samza 0.8.0 >>>> (incubating). >>>>> This is our second release in the Apache Incubator. Thanks to >>>>>everyone >>>> who >>>>> has contributed to this release. >>>>> >>>>> The release candidate can be downloaded from here: >>>>> >>>>> http://people.apache.org/~criccomini/samza-0.8.0-rc0/ >>>>> >>>>> The release candidate is signed with pgp key 980AF123CF9730D3, which >>>>>is >>>>> included in the repository's KEYS file: >>>>> >>>>> >>>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=incubator-samza.git;a=blob_pl >>>>ain;f=KEYS;h=7c59d68a82a6b6172334725962583b2fa8071242;hb=HEAD >>>>> >>>>> and can also be found on keyservers: >>>>> >>>>> http://pgp.mit.edu/pks/lookup?op=get&search=0x980AF123CF9730D3 >>>>> >>>>> The git tag is release-0.8.0-rc0 and signed with the same pgp key: >>>>> >>>>> >>>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=incubator-samza.git;a=tag;h=r >>>>efs/tags/release-0.8.0-rc0 >>>>> >>>>> Test binaries have been published to Maven's staging repository, and >>>>>are >>>>> available here: >>>>> >>>>> >>>>>https://repository.apache.org/content/repositories/orgapachesamza-1003 >>>>>/ >>>>> >>>>> Note that the binaries were built with JDK6 without incident. >>>>> >>>>> 136 issues were resolved for this release: >>>>> >>>>> >>>>> >>>> >>>>https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND% >>>>20fixVersion%20%3D%200.8.0%20AND%20status%20in%20(Resolved%2C%20Closed) >>>>> >>>>> The vote will be open for 72 hours. Please download the release >>>> candidate, >>>>> check the hashes/signature, build it and test it, and then please >>>>>vote: >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> +1 from my side for the release. >>>>> >>>>> Thanks, >>>>> Chris >>>>> >>>> >> >
