Hi Charles, We're definately interested in memory usage improvements and optimisations for the 1.5 release next year.
One problem I can see with your change is that FileInputStream does not necessarily support "markSupported()", so you're changing the semantics of the code, as previously all FileInputStream instances would have entered the if statement. Could you take a look at how the actual InputStream is used and point out specific areas of code where using the "markSupported" input stream is more efficient than the existing code? Colm. On Wed, Dec 22, 2010 at 6:56 PM, Charles Bosquet <[email protected]> wrote: > hey all, > I'am new to Santuario, but there is may be an improvement about memory usage > in XMLSignatureInput file to reduce memory usage : > I can see in source XMLSignatureInput code : > "if (_inputOctetStreamProxy instanceof FileInputStream) {" > But il may be replaced by : > "if (_inputOctetStreamProxy.markSupported()) {" > This modification avoids ByteArrayInputStream usuage in some cases : if we > verify a signature on a non FileInputStream but "resatable" actual code use > ByteArrayInputStream... > I can give you real world cases if needed. > Best regards > Charles BOSQUET (FRANCE...sorry for my english)
