dmatej commented on PR #101: URL: https://github.com/apache/santuario-xml-security-java/pull/101#issuecomment-1383845499
This is not a bug fix but rather a refactoring with tested result. How could you do that? Yeah, I could avoid some updates and reordering, but trivial diffs can do gitbot and if I would have to wait for every review for weeks, I would never finish. So this is something like a transaction, a change from one consistent state to another. The last push is just a rebase, I should have done probably rather a merge than this, that's true. Cutting that to small pieces doesn't bring anything, just more work. Yes, reviewing large pr by reading is not easy, especially with github browser. This project would need several large refactoring iterations... next generation. Another option is to fork the project and move quickly forward with own reviews in hours/days, but cooperation is better, even when sometimes somebody comes with scary radical changes (tested!). Another option is to replace this dependency with something in a better shape. So, simply said, if you refuse this pr, make a decision. But honestly, reviewing it still takes much less time and effort than implementing and testing it. Someone has to do that... both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@santuario.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
